Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

#1526 Ensure exact match when installing Arduino_BuiltIn on the first IDE2 startup #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kittaakos merged 1 commit into main from #1526
Oct 7, 2022

Conversation

Copy link
Contributor

@kittaakos kittaakos commented Oct 5, 2022 •
edited
Loading

Motivation

(削除) This PR depends on #1530. (削除ここまで) ✅

This PR ensures that the Arduino_BuiltIn will be installed on the first start in case of absence.

Change description

Other information

To verify:

Closes #1526

Local verification after wiping the localStorage content and starting IDE2.

Platform arduino:avr@1.8.5 already installed
Already installed Servo@1.1.8
Already installed Stepper@1.1.3
Already installed Ethernet@2.0.1
Already installed Firmata@2.5.8
Already installed Keyboard@1.0.4
Already installed LiquidCrystal@1.0.7
Already installed Mouse@1.0.1
Already installed SD@1.2.4
Already installed TFT@1.0.6
Already installed Arduino_BuiltIn@1.0.0

Platform arduino:avr@1.8.5 already installed
Already installed Keyboard@1.0.4
Already installed Stepper@1.1.3
Already installed Firmata@2.5.8
Already installed SD@1.2.4
Already installed Ethernet@2.0.1
Already installed Mouse@1.0.1
Already installed Arduino_BuiltIn@1.0.0
Already installed Servo@1.1.8
Already installed TFT@1.0.6
Already installed LiquidCrystal@1.0.7

Platform arduino:avr@1.8.5 already installed
Already installed Stepper@1.1.3
Already installed TFT@1.0.6
Already installed Servo@1.1.8
Already installed SD@1.2.4
Already installed LiquidCrystal@1.0.7
Already installed Mouse@1.0.1
Already installed Arduino_BuiltIn@1.0.0
Already installed Firmata@2.5.8
Already installed Keyboard@1.0.4
Already installed Ethernet@2.0.1

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 5, 2022
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

 

on the first IDE2 startup.
Closes #1526
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

+1 more reviewer

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect libraries installed by first run installation

AltStyle によって変換されたページ (->オリジナル) /