-
-
Notifications
You must be signed in to change notification settings - Fork 490
#1525 Removed the real_name of the libraries
#1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It has been removed from the gRPC API: arduino/arduino-cli#1890 This PR switches from `real_name` to `name` in the UI, as the `name` is the canonical form provided by the CLI. Closes #1525 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well for me. Using getName() instead of getRealName() and grouping by name the examples it behaves as expected👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working perfectly for me. Thanks Akos!
Thank you for the quick review ❤️
Motivation
Align gRPC APIs with the most recent Arduino CLI. The
Library#real_namehas been removed from the gRPC API: arduino/arduino-cli#1890This PR switches from
real_nametonamein the UI, as thenameis the canonical form provided by the CLI.Change description
Other information
How to verify:
SparkFun color lcdin the search<input>, (expected a single result:SparkFun Color LCD Shield)UNINSTALL,SparkFun Color LCD Shield@1.0.1,File>Examples> verify that you seeSparkFun Color LCD Shieldas the grouping menu item. Like this:Screen Shot 2022年10月05日 at 11 50 02
Closes #1525
Reviewer checklist