-
-
Notifications
You must be signed in to change notification settings - Fork 491
Avoid intellisense widgets being covered by the bottom panel #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA assistant check
All committers have signed the CLA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @r3inbowari!
Your change fixes the issue, although I would prefer increasing the z-index of the #theia-main-content-panel instead of setting a negative value for the #theia-bottom-content-panel. This way, we make sure that any sibiling of the main content panel will have a lower z-index than its own – for example, in the situation we add a new widget there, we would incur in the same issue again.
Something like this should work:
#theia-main-content-panel {
z-index: 1
}
Agree :) Also fixed SplitPanel-handle showing above intellisense widget.
from:
1663842466981
to:
1663842423909
This looks even better! I tested it and it works perfectly 😺
Thank you so much!
b6bc5a3 to
dc6c851
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @r3inbowari!
Motivation
Avoid the problem that the Intellisense widget may be cover by the bottom(Output) panel partially.
Change description
from:
image
to:
image
Other information
Reviewer checklist