Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Retain Library/Boards Manager installation interface using version menu #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francescospissu merged 1 commit into main from fspissu/retain-install-interface
Oct 13, 2022

Conversation

Copy link
Contributor

@francescospissu francescospissu commented Sep 20, 2022 •
edited
Loading

Motivation

If the version selected from the drop-down menu overlaps the next element, the focus on the current element is lost and the "INSTALL" button is no longer visible. Details here.

Change description

Keep the footer visible until installation is performed. (NOTE: The selection from the drop-down menu is not visible in the video because it wasn't captured by the screen recorder).

sketch_jun14a._.Arduino.IDE.2.0.0.2022年10月06日.10-17-18.mp4

Other information

Closes #1425.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

per1234 reacted with thumbs up emoji
@francescospissu francescospissu added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 20, 2022
@francescospissu francescospissu marked this pull request as ready for review October 6, 2022 08:26
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super nice. Thanks Francesco!

francescospissu reacted with thumbs up emoji
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, both code and behaviour, but let's wait for an approval from @91volt before merging this PR.

francescospissu reacted with thumbs up emoji
Copy link

@91volt 91volt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@francescospissu francescospissu deleted the fspissu/retain-install-interface branch October 13, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@91volt 91volt 91volt approved these changes

@davegarthsimpson davegarthsimpson Awaiting requested review from davegarthsimpson

+1 more reviewer

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retain Library/Boards Manager installation interface following version menu selection

AltStyle によって変換されたページ (->オリジナル) /