-
-
Notifications
You must be signed in to change notification settings - Fork 488
#1441 Fix input background in Firmware Updater dialog #1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@francescospissu
francescospissu
requested review from
ubidefeo,
davegarthsimpson and
91volt
September 19, 2022 12:48
@francescospissu
francescospissu
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Sep 19, 2022
AlbyIanna
AlbyIanna
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the Firmware Updater dialog the "Select a board..." input has a contrast issue. See details here.
Change description
Changed the background of the input accordingly with the selected theme.
Dark:
Screenshot 2022年09月19日 120427
Screenshot 2022年09月19日 120538
Screenshot 2022年09月19日 120613
Light:
Screenshot 2022年09月19日 144537
Screenshot 2022年09月19日 144607
Screenshot 2022年09月19日 144647
Other information
Closes #1441.
Reviewer checklist