Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

#1431 Add missing translations #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kittaakos merged 1 commit into arduino:main from kittaakos:#1431
Sep 26, 2022
Merged

#1431 Add missing translations #1449

kittaakos merged 1 commit into arduino:main from kittaakos:#1431
Sep 26, 2022

Conversation

Copy link
Contributor

@kittaakos kittaakos commented Sep 16, 2022 •
edited
Loading

Motivation

Add the missing translations.

Was fixed:

Language pack changes:

  • Downgraded the following language packs to 1.53.2:
    • French (fr),
    • Chinese (Simplified) (zh-hans),
    • German (de),
    • Japanese (ja),
    • Turkish (tr),
    • Italian (it),
    • Russian (ru),
    • Spanish (es),
    • Portuguese (Brazil) (pt-BR), and
    • Czech (cs).
  • Added the following language packs:
    • Hungarian (hu) [1.48.3],
    • Bulgarian (bg) [1.48.3],
    • Polish (id) [1.53.2],
    • Ukrainian (uk) [1.48.3], and
    • Korean (ko) [1.53.2].

WONT FIX:

Context menu item in view containers, such as Debug view:
Screen Shot 2022年09月14日 at 17 29 03

Change description

Other information

Closes #1431

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 16, 2022
Copy link
Contributor Author

@per1234, any ideas on how we can verify these changes? Translations won't be available by the time the review happens. So we cannot verify that it works. Thank you!

Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me ✅

Copy link
Contributor Author

This PR should contain #1462.

 

Aligned the languge pack versions.
Closes arduino#1431
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved code changes and behaviour. Thanks Akos!

kittaakos reacted with heart emoji
@kittaakos kittaakos merged commit 9ef04bb into arduino:main Sep 26, 2022
Reviewers

@per1234 per1234 per1234 approved these changes

+1 more reviewer

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing localization for locales with available language pack Add missing translations

AltStyle によって変換されたページ (->オリジナル) /