-
-
Notifications
You must be signed in to change notification settings - Fork 492
#1055 Install the Arduino_BuiltIn to built-in location
#1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPDATE: fixed by arduino/arduino-cli@fb57a52
Describe the problem
"built-in" libraries installation fails.
To reproduce
- Select File > Quit from the Arduino IDE menus if it is running.
- Delete the "User Data Folder" to adequately simulate a fresh install.
- Windows:
C:\Users\<user name>\AppData\Roaming\arduino-ide - Linux:
~/.config/arduino-ide - macOS:
~/Library/Application Support/arduino-ide
- Windows:
- Start the Arduino IDE
🐛 The "built-in" libraries installation fails:
Failed to install library: Arduino_BuiltIn:1.0.0.
Error: 2 UNKNOWN: Builtin libraries directory not set
Expected behavior
Arduino IDE automatically configures Arduino CLI for the built-in libraries installation.
Arduino IDE version
2.0.0-rc9.2.snapshot-8bb5c61 (tester build for 092ca2d)
Operating system
Windows
Operating system version
10
Additional context
The required directories.builtin.libraries configuration key is not present in ~/.arduinoIDE/arduino-cli.yaml.
(削除) https://github.com/cmaglie/arduino-cli/blob/byebye_bundles/docs/configuration.md#configuration-keys
(削除ここまで)
Closes #1055. Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Arduino_BuiltIn to built-in location (削除ここまで)Arduino_BuiltIn to built-in location (追記ここまで)
092ca2d to
fb588a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code-wise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working perfectly now.
I verified that this change will align the behavior of the Arduino IDE 2.x "built-in" libraries with that of Arduino IDE 1.x, where they will have a lower "location priority" than platform bundled libraries.
Thanks Akos!
Thank you for the review.
On-hold until arduino/arduino-cli#1817 is merged.
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Motivation
Use a dedicated install location for the
Arduino_BuiltInlib on the first IDE2 start.Change description
From now on, the built-in lib will be installed into the
built-inlocation of the CLI.Closes #1055.
Other information
Reviewer checklist