-
-
Notifications
You must be signed in to change notification settings - Fork 488
#1016, #1274 Aligned the "Save your sketch" dialog behavior #1351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4424214 to
68e58d5
Compare
ubidefeo
commented
Aug 26, 2022
@kittaakos
I have found that when launching this build the automatically opened sketch is the first one listed in my Sketchbook.
The last one I had opened was an example (which I did not save, of course).
In case no previously open sketch is available to open again, it should do as IDE 1.x does: open a new Sketch
this build the automatically opened sketch is the first one listed in my Sketchbook.
In case no previously open sketch is available
@ubidefeo, but there is a sketch to open 👆 , the first one from the Sketchbook. If you delete ~/.arduinoIDE/recent-sketches.json and ~/.arduinoIDE/recentworkspace.json, the IDE2 should open a new temp sketch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describe the problem
Sketch tab becomes closable after rename.
To reproduce
- Click the ●くろまる●くろまる●くろまる icon on the right side of the editor toolbar.
- Select "New Tab" from the menu.
- In the "Name for new file" field, type
foo - Click the OK button.
🙂 The "foo.ino" tab does not have an X icon. - Click the ●くろまる●くろまる●くろまる icon on the right side of the editor toolbar.
- Select "Rename" from the menu.
- In the "New name for file" field, type
bar.ino
🐛 The "bar.ino" tab has an X icon.
Arduino IDE version
2.0.0-rc9.2.snapshot-948a6ed (tester build for 9a2d13f)
Operating system
Windows 10
The last one I had opened was an example (which I did not save, of course).
In case no previously open sketch is available to open again, it should do as IDE 1.x does: open a new Sketch
I have tried it, and the IDE (1.x) opens the example. Steps to reproduce:
- Open IDE (1.x),
- Open an example (I picked the
File>Examples>01. Basic>AnalogReadSerial), - Close all other sketches if you have any but the
AnalogReadSerial, - Quit the IDE (1.x),
- Open the IDE (1.x),
- You have the
AnalogReadSerialsketch opened.
The IDE2 never behaved like this 👆 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describe the problem
Regression of #831
Closability of tabs for files in the src subfolder was lost.
To reproduce
- Put this "HasSrcFolder" sketch to your sketchbook: HasSrcFolder.zip
- Open the "HasSrcFolder" sketch in the Arduino IDE.
- Select File > Preferences... from the Arduino IDE menus.
- Check the box next to "☐ Show files inside Sketches".
- Click the OK button.
- Open the "Sketchbook" view.
- Click on HasSrcFolder/src/InSrcFolder.cpp
🐛 There is no X icon on the InSrcFolder.cpp tab.
Expected behavior
Tabs for files in the src subfolder are closable, as is the behavior of the IDE build from the main branch:
Arduino IDE version
2.0.0-rc9.2.snapshot-948a6ed (tester build for 9a2d13f)
Operating system
Windows 10
Additional context
See #831 for details on why closability of these files specifically is needed.
See #946 for the original code change that enabled this closability.
ubidefeo
commented
Aug 26, 2022
@kittaakos
I checked and there's a misalignment of behaviour.
IDE 1.x still allows you to have the app open without any workspaces.
If you close the example (not quitting the IDE) so that no windows are open, once you quit the IDE and relaunch it you get a new sketch.
I think opening anything that was available at quit is a good behaviour, but if nothing was then it should not pick the first sketch from the sketchbook but rather create a new sketch
7. In the "New name for file" field, type
bar.ino
🐛 The "bar.ino" tab has an X icon.
Closability of tabs for files in the
srcsubfolder was lost.
Thank you for the steps, Per. Both issues should be fixed now.
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
and then the window. Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Closes #660 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Closes #1034. Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
f1574ff to
6a924da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that it fixes all targeted issues:
As well as the two problems I reported via my previous reviews:
Uh oh!
There was an error while loading. Please reload this page.
Motivation
Change description
Other information
Closes #1016
Closes #1274
Closes #1026
Closes #660
Closes #1034
Closes #994
Reviewer checklist