-
-
Notifications
You must be signed in to change notification settings - Fork 489
Align functional max-min of scale stepper to actual max-min zoom level #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davegarthsimpson
merged 1 commit into
main
from
align-scale-stepper-with-actual-max-min
Aug 24, 2022
Merged
Align functional max-min of scale stepper to actual max-min zoom level #1345
davegarthsimpson
merged 1 commit into
main
from
align-scale-stepper-with-actual-max-min
Aug 24, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@per1234
per1234
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Aug 24, 2022
francescospissu
francescospissu
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@davegarthsimpson
davegarthsimpson
deleted the
align-scale-stepper-with-actual-max-min
branch
August 24, 2022 10:32
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Small fix for correctness. we are yet to decide whether or not to impose a specific max/min level of zoom in the IDE, in the meantime, to avoid confusion we should ensure the max-min zoom of the scale stepper reflects the actual max-min zoom of the application.
Change description
Changes hard coded max-min values used by the scale stepper.
Reviewer checklist