Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Use Task to build pinned CLI for IDE #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kittaakos merged 1 commit into main from #1313
Aug 11, 2022
Merged

Use Task to build pinned CLI for IDE #1315

kittaakos merged 1 commit into main from #1313
Aug 11, 2022

Conversation

Copy link
Contributor

@kittaakos kittaakos commented Aug 10, 2022 •
edited by per1234
Loading

Motivation

To show the exact CLI version (commit hash) in IDE when IDE is using a pinned version, not yet released CLI.

Change description

  • Updated the GH workflow and make Task available,
  • Changed the CLI downloader to use task instead of go when a CLI ought to be produced on the fly.

Other information

It's recommended for devs to install Task on the dev env. See here.

Closes #1313

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself status: on hold Do not proceed at this time labels Aug 10, 2022 
Closes #1313
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Copy link
Contributor Author

The behavioral change cannot be approved in this PR. I made #1310 depend on this PR. As a result, if a build is produced from #1310, the About dialog should show this CLI commit hash instead of 0.0.0-git

Screen Shot 2022年08月10日 at 14 04 10

The de6ae8c0 is currently pointing to the CLI PR here.

Screen Shot 2022年08月10日 at 14 15 01

per1234 reacted with thumbs up emoji

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks Akos!

@kittaakos kittaakos marked this pull request as ready for review August 10, 2022 14:50
@kittaakos kittaakos removed the status: on hold Do not proceed at this time label Aug 10, 2022
@kittaakos kittaakos merged commit a39ab47 into main Aug 11, 2022
@kittaakos kittaakos deleted the #1313 branch August 11, 2022 07:28
@kittaakos kittaakos added conclusion: resolved Issue was resolved topic: CLI Related to Arduino CLI labels Aug 11, 2022
@per1234 per1234 changed the title (削除) Use Task to build pinned CLI for IDE2. (削除ここまで) (追記) Use Task to build pinned CLI for IDE (追記ここまで) Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IDE2 nighty build should show the exact CLI version instead of CLI Version: 0.0.0-git []

AltStyle によって変換されたページ (->オリジナル) /