Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix dialogs UI scalability #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbyIanna merged 8 commits into main from fix-dialogs-ui
Aug 18, 2022
Merged

Fix dialogs UI scalability #1311

AlbyIanna merged 8 commits into main from fix-dialogs-ui
Aug 18, 2022

Conversation

Copy link
Contributor

@AlbyIanna AlbyIanna commented Aug 9, 2022
edited
Loading

Motivation

As explained in #1309, our dialogs might become distorted when scaling up the UI (from the settings or using the shortcut CMD/CTRL + '+').

I've made some fixes in order to make the interface readable and usable with an interface that is scaled up to 200%, with a minimum window size of 450px in width and 300px in height. Maybe they won't look beautiful, but every dialog should be at least usable and readable up to that size.

Change description

Here's a list of screen captures before the changes, with an interface scale of 200% and a window size of 450x300:

Settings dialog

Screenshot 2022年08月09日 at 09 32 25

IDE auto-update dialog

Screen.Recording.2022年08月09日.at.09.39.43.mov

Select Board dialog

Screen.Recording.2022年08月09日.at.09.42.53.mov

WiFi 101/WiFi NINA Firmware Updater dialog

Screenshot 2022年08月09日 at 09 46 08

Upload SSL Root Certificates

Screenshot 2022年08月09日 at 09 48 34


And after the changes:

Settings dialog

Screen.Recording.2022年08月09日.at.09.29.03.mov

To avoid the '%' symbol unexpectedly going to a new line, I've added a unitOfMeasure prop to the settings-step-input component: a9ed5b5

IDE auto-update dialog

Screen.Recording.2022年08月09日.at.09.37.09.mov

I needed to apply a major refactor on this dialog in order to move the buttons from the content of the dialog (which is the inner react component) to the footer (which is part of the AbstractDialog inherited from Theia): 553c6fe

Select Board dialog

Screen.Recording.2022年08月09日.at.09.42.38.mov

Here I've decided to save some space when the size of the window is very small by adding a media query that removes the upper text paragraph on screen heights smaller than 400px: f8f07ea62be6d96191759c89da26c7fb5327c0fff8f07ea62be6d96191759c89da26c7fb5327c0ff

WiFi 101/WiFi NINA Firmware Updater dialog

Screenshot 2022年08月09日 at 09 45 54

Upload SSL Root Certificates

Screen.Recording.2022年08月09日.at.09.47.55.mov

Other information

Fixes #1309

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time and making the screencasts about the expected behavior. Very nice 👍

@AlbyIanna AlbyIanna force-pushed the fix-dialogs-ui branch 4 times, most recently from dad0c76 to 26cbba6 Compare August 10, 2022 08:30
@AlbyIanna AlbyIanna marked this pull request as draft August 10, 2022 08:33
Copy link
Contributor Author

AlbyIanna commented Aug 10, 2022
edited
Loading

I've put the PR back in draft because I've decreased the IDE version for testing purposes: 26cbba6

UPDATE:
changes are reverted, PR is ready

@AlbyIanna AlbyIanna force-pushed the fix-dialogs-ui branch 2 times, most recently from 3bf97b5 to bfecd88 Compare August 11, 2022 11:09
@AlbyIanna AlbyIanna marked this pull request as ready for review August 11, 2022 11:09
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 11, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvements Alberto!

Reviewers

@per1234 per1234 per1234 approved these changes

@davegarthsimpson davegarthsimpson davegarthsimpson approved these changes

@91volt 91volt 91volt approved these changes

+1 more reviewer

@kittaakos kittaakos kittaakos left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve styling of dialogs to avoid unwanted layout shift when scaling up the application

AltStyle によって変換されたページ (->オリジナル) /