-
-
Notifications
You must be signed in to change notification settings - Fork 490
#575, #1175 Show 'progress' indicator during verify/upload #1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
arduino-ide-extension/src/browser/widgets/component-list/component-list-item.tsx
Outdated
Show resolved
Hide resolved
72b89d8
to
e475926
Compare
633fd9c
to
3789ec4
Compare
ubidefeo
commented
Jul 28, 2022
The progress indicator works as expected.
Opening the output panel right at the beginning of verify is helping a lot in moving the attention to the bottom of the window, where the progress can be noticed easy.
I have seen at the end of the ESP32 platform installation that a longer message appears in the output panel, I guess this is expected?
Installing esp32:riscv32-esp-elf-gcc@gcc8_4_0-esp-2021r2-patch3
esp32:riscv32-esp-elf-gcc@gcc8_4_0-esp-2021r2-patch3 installed
Installing esp32:xtensa-esp32-elf-gcc@gcc8_4_0-esp-2021r2-patch3
esp32:xtensa-esp32-elf-gcc@gcc8_4_0-esp-2021r2-patch3 installed
Installing esp32:xtensa-esp32s2-elf-gcc@gcc8_4_0-esp-2021r2-patch3
esp32:xtensa-esp32s2-elf-gcc@gcc8_4_0-esp-2021r2-patch3 installed
Installing esp32:xtensa-esp32s3-elf-gcc@gcc8_4_0-esp-2021r2-patch3
esp32:xtensa-esp32s3-elf-gcc@gcc8_4_0-esp-2021r2-patch3 installed
Installing esp32:esptool_py@3.3.0
esp32:esptool_py@3.3.0 installed
Installing esp32:mkspiffs@0.2.3
esp32:mkspiffs@0.2.3 installed
Installing esp32:mklittlefs@3.0.0-gnu12-dc7f933
esp32:mklittlefs@3.0.0-gnu12-dc7f933 installed
Installing platform esp32:esp32@2.0.3
Configuring platform.
Platform esp32:esp32@2.0.3 installed
cc @per1234
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but I have only one remark.
I noticed that it's possible to trigger an Upload when there's a Verify in progress, and vice versa it's possible to trigger a Verify when there's an Upload in progress. Maybe this is expected (in the end it doesn't seem to cause any significant issue). I'm pointing this out because it feels weird to click on the Upload button and get feedback (the yellow active status) on the Verify button, while the Upload button is still clickable.
Screen.Recording.2022年07月29日.at.17.15.55.mov
Thanks for taking the time and trying it out.
I noticed that it's possible to trigger an Upload when there's a Verify in progress, and vice versa it's possible to trigger a Verify when there's an Upload in progress. Maybe this is expected (in the end it doesn't seem to cause any significant issue)
It's the same in the main
too. So this did not change anything.
Screen Shot 2022年07月29日 at 17 29 28
I'm pointing this out because it feels weird to click on the Upload button and get feedback (the yellow active status) on the Verify button
Good that you brought this up; it's mentioned in the description as expected behavioral changes. I am looking forward to hearing how it should exactly work. I can restore what it is on the main
, but you also noticed the behavior does not seem correct, right?
while the Upload button is still clickable.
This is undesired. Thanks for noting it. I will change the logic so that when the user clicks on Upload
, the following will happen:
- upload turns into yellow,
- verify starts (verify button yellow, upload is still yellow),
- verify completes (only upload is yellow),
- upload completes (zero yellow buttons)
I am looking forward to hearing how it should exactly work.
I don't really know. The Java IDE didn't have this issue because it turns yellow only one button: if you click on the Upload button, the Upload button is the only one that turns yellow (even during the compile process), and clicking the Verify button during this time wouldn't do anything, making it disabled for all intents. But anyway, as you said, it's not in this PR's scope to solve this issue 👍
upload turns into yellow,
verify starts (verify button yellow, upload is still yellow),
verify completes (only upload is yellow),
upload completes (zero yellow buttons)
I like this, thanks!
Let's add @91volt to the thread and see what he thinks about this solution.
3789ec4
to
d930d8f
Compare
I am looking forward to hearing how it should exactly work.
I don't really know. The Java IDE didn't have this issue because it turns yellow only one button: if you click on the Upload button, the Upload button is the only one that turns yellow (even during the compile process), and clicking the Verify button during this time wouldn't do anything, making it disabled for all intents. But anyway, as you said, it's not in this PR's scope to solve this issue 👍
upload turns into yellow,
verify starts (verify button yellow, upload is still yellow),
verify completes (only upload is yellow),
upload completes (zero yellow buttons)I like this, thanks!
I reverted all the UX changes. The Verify
and Upload
UX should be the same as the main
state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really nice advancement in the user experience. Thanks Akos!
I noticed that it's possible to trigger an Upload when there's a Verify in progress, and vice versa it's possible to trigger a Verify when there's an Upload in progress.
This bug is now being tracked at #1299
Uh oh!
There was an error while loading. Please reload this page.
Motivation
Show progress indication when running the
verify
,upload
,upload using programmer
orburn bootloader
commands from IDE2.The changes in action:
Verify.mp4
Upload.mp4
Change description
compile
beforeverify
; it's the caller's responsibility to run it.Other information
(削除) Noteworthy UI/UX changes: (削除ここまで)(削除) AnUpload
consists of two tasks:Verfiy
andUpload
. With the proposed changes, users will see on the toolbar (Verify toolbar icon is yellow with the light Arduino theme) that ifVerify
is in progress, thenUpload
is in progress. See in action. (削除ここまで)(削除) https://user-images.githubusercontent.com/1405703/181474498-14e02b6b-1f4e-4b07-b93c-7e819f874e8e.mp4 (削除ここまで)(削除) This is a UI change compared to theHEAD
of themain
branch, but I believe this is the correct solution What do you think @per1234 and @ubidefeo? (削除ここまで)For reviewers:
Verify
/Upload
,Closes #575
Closes #1175
Reviewer checklist