Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

#1205: improve "broken UI" with settings dialog when app is scaled up #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davegarthsimpson merged 1 commit into main from 1205-settings-dialog-scaling
Jul 28, 2022

Conversation

Copy link
Contributor

@davegarthsimpson davegarthsimpson commented Jul 26, 2022

Motivation

Settings dialog reported as visually unpleasing, and functionally impaired when scaling up the IDE.

Change description

Uses a fixed footer and overflow: auto for settings dialog content.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Copy link
Contributor

I've tried it, and I think this is a good solution in IDE2 👍

Copy link
Contributor

@francescospissu francescospissu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected 👍

Copy link
Contributor

AlbyIanna commented Jul 27, 2022 •
edited
Loading

The issue is spread across all the dialogs.

This PR fixes #1205, but doesn't solve the issue for other dialogs.

e.g.: the Select Board dialog
image

I believe we should solve it at the root. Here I made an experiment, but it raised some other scrolling issues, so I didn't open a PR.
davegarthsimpson reacted with thumbs up emoji

Copy link
Contributor Author

davegarthsimpson commented Jul 27, 2022 •
edited
Loading

The issue is spread across all the dialogs.

This PR fixes #1205, but doesn't solve the issue for other dialogs.

I believe we should solve it at the root. Here I made an experiment, but it raised some other scrolling issues, so I didn't open a PR.

I would solve case by case, as the dialogs can vary greatly, we may want a different design / UX for each, e.g. it's clearly not nice if scrollable elements also have a scrollable parent.

We can create separate PRs for any other dialogs that are broken in the same way.
AlbyIanna reacted with thumbs up emoji

@davegarthsimpson davegarthsimpson deleted the 1205-settings-dialog-scaling branch July 28, 2022 15:38
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescospissu francescospissu francescospissu approved these changes

@91volt 91volt Awaiting requested review from 91volt

+1 more reviewer

@fstasi fstasi fstasi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The min window size is fixed in IDE2, but the Settings dialog does not scale well

AltStyle によって変換されたページ (->オリジナル) /