Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Resize sidebar icons #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francescospissu merged 1 commit into main from sidebar-icons
Jul 19, 2022
Merged

Resize sidebar icons #1217

francescospissu merged 1 commit into main from sidebar-icons
Jul 19, 2022

Conversation

Copy link
Contributor

@francescospissu francescospissu commented Jul 19, 2022

Motivation

The icons in the sidebar must be resized.

Change description

Decrease the icons size.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@francescospissu francescospissu marked this pull request as ready for review July 19, 2022 11:58
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

francescospissu reacted with thumbs up emoji
@francescospissu francescospissu deleted the sidebar-icons branch July 19, 2022 12:37
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 20, 2022
Copy link
Contributor

Hi, Internet people say there are better ways to load and use a custom font in the web app than this, as it takes time, causes performance problems, and is noticeable.

font-load.mp4

Screen Shot 2023年03月07日 at 11 18 05

Screen Shot 2023年03月07日 at 11 18 10

Another thing I need help understanding is how the new font relates to the sidebar icon size in this PR. I am referring to this change: https://github.com/arduino/arduino-ide/pull/1217/files#diff-30d42744c8ff8ad2ab080f1eae83f81a355d573dcc90b6d1c351b68be42321bdR1-R4

How do you FE guys do in other apps? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@91volt 91volt 91volt approved these changes

+1 more reviewer

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /