-
-
Notifications
You must be signed in to change notification settings - Fork 491
Add typing support to steppers #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's working very nicely. Thank you for the cleanup ❤️
I have noticed this:
- set the zoom level to
14%
, - UI scales, ✅
- Open
Preferences: Open Settings (JSON)
, - See the
"arduino.window.zoomLevel": -4.3,
entry, - The Arduino preferences say:
Adjust the zoom level of the window. The original size is 0 and each increment above (e.g. 1) or below (e.g. -1) represents zooming 20% larger or smaller. You can also enter decimals to adjust the zoom level with a finer granularity.
So technically, the user can set an invalid preference value, or at least be out of sync with the preferences.
I have noticed this:
- set the zoom level to
14%
,- UI scales, ✅
- Open
Preferences: Open Settings (JSON)
,- See the
"arduino.window.zoomLevel": -4.3,
entry,- The Arduino preferences say:
Adjust the zoom level of the window. The original size is 0 and each increment above (e.g. 1) or below (e.g. -1) represents zooming 20% larger or smaller. You can also enter decimals to adjust the zoom level with a finer granularity.
So technically, the user can set an invalid preference value, or at least be out of sync with the preferences.
Thanks for the finding! Hmm, so I guess we should always restrict to nearest valid numbers?
Or is this a case of needing to update what are considered valid settings?
so I guess we should always restrict to nearest valid numbers
I propose leaving it as is if it works reliably and seems to work nicely. Let's adjust the scaling when we switch to the scaling from Code.
Motivation
To allow users to change font size and app scaling with the keyboard.
Change description
Use a custom controlled input component for the desired functionality.
Reviewer checklist