-
-
Notifications
You must be signed in to change notification settings - Fork 488
Toolbar enhancements #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Toolbar enhancements #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@francescospissu
francescospissu
requested review from
fstasi,
AlbyIanna and
91volt
July 15, 2022 11:02
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@francescospissu
francescospissu
force-pushed
the
fspissu/toolbar-update
branch
from
July 18, 2022 11:01
440ccd2 to
6bd2aef
Compare
AlbyIanna
AlbyIanna
suggested changes
Jul 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it's good, nice job!
I've just made some suggestions to have a cleaner code (in particular the CSS)
arduino-ide-extension/src/browser/arduino-frontend-contribution.tsx
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/arduino-frontend-contribution.tsx
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/serial/plotter/plotter-frontend-contribution.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Alberto Iannaccone <a.iannaccone@arduino.cc>
Co-authored-by: Alberto Iannaccone <a.iannaccone@arduino.cc>
fstasi
fstasi
approved these changes
Jul 18, 2022
...de into fspissu/toolbar-update
Co-authored-by: Alberto Iannaccone <a.iannaccone@arduino.cc>
AlbyIanna
AlbyIanna
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Look at this wonderful new UI 🤩
LGTM 🚀
@per1234
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Jul 18, 2022
91volt
91volt
approved these changes
Jul 18, 2022
kittaakos
pushed a commit
to kittaakos/arduino-ide
that referenced
this pull request
Aug 17, 2022
The icons were removed in arduino#1194. Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The toolbar needs to be updated with new icons, different sizes and other graphical improvements to reflect the new design system.
Change description
Graphic updates based on new specifications.
Reviewer checklist