-
-
Notifications
You must be signed in to change notification settings - Fork 491
Update themes #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update themes #1187
Conversation
b905f9e to
588f720
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This doesn't seem enough to fix #1180 though, because it shows the yellow button only when pressing "Verify" and not when pressing "Upload".
I'll open a separate PR to solve that since this PR is the auto-generated one for updating theme colors.
About the High Contrast and Theia themes, we're having a discussion about it and we're probably going to solve it separately.
it shows the yellow button only when pressing "Verify" and not when pressing "Upload"
The bug is being tracked here @AlbyIanna: #173 (comment)
it shows the yellow button only when pressing "Verify" and not when pressing "Upload"
The bug is being tracked here @AlbyIanna: #173 (comment)
Ah! #1180 is only referring to the Verify button. My bad!
Automated changes by create-pull-request GitHub action