Add language packs #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

AlbyIanna merged 1 commit into main from add-language-packs

Jul 15, 2022

Merged

Add language packs #1166

AlbyIanna merged 1 commit into main from add-language-packs

Jul 15, 2022

Conversation

AlbyIanna

Copy link

Contributor

@AlbyIanna AlbyIanna commented Jul 11, 2022

Motivation

As on Transifex we are getting more and more strings translated we want to add support for new languages.

Other information

Reviewer checklist

PR addresses a single concern.
The PR has no duplicates (please search among the Pull Requests before creating one)
PR title and description are properly filled.
Docs have been added / updated (for bug fixes / features)

@AlbyIanna AlbyIanna requested review from fstasi and per1234

July 11, 2022 07:45

@per1234 per1234 added the type: enhancement label

Jul 11, 2022

per1234

per1234 requested changes

Jul 12, 2022

View reviewed changes

Copy link

Contributor

@per1234 per1234 left a comment •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPDATE: fixed by https://github.com/arduino/arduino-ide/compare/7cc25ccbc14644b0955ca807019cd875a44e08e3..55e83a89d82903b2f21ce47d5fd5d4d3f842480c

(削除) It is necessary to also add these to the `theiaPlugins` key of `electron/build/template-package.json`:

arduino-ide/electron/build/template-package.json

Lines 142 to 154 in 7fed8fe

"theiaPlugins": {

"vscode-builtin-cpp": "https://open-vsx.org/api/vscode/cpp/1.52.1/file/vscode.cpp-1.52.1.vsix",

"vscode-arduino-tools": "https://downloads.arduino.cc/vscode-arduino-tools/vscode-arduino-tools-0.0.2-beta.2.vsix",

"vscode-builtin-json": "https://open-vsx.org/api/vscode/json/1.46.1/file/vscode.json-1.46.1.vsix",

"vscode-builtin-json-language-features": "https://open-vsx.org/api/vscode/json-language-features/1.46.1/file/vscode.json-language-features-1.46.1.vsix",

"cortex-debug": "https://open-vsx.org/api/marus25/cortex-debug/0.3.10/file/marus25.cortex-debug-0.3.10.vsix",

"vscode-language-pack-nl": "https://open-vsx.org/api/MS-CEINTL/vscode-language-pack-nl/1.48.3/file/MS-CEINTL.vscode-language-pack-nl-1.48.3.vsix",

"vscode-language-pack-fr": "https://open-vsx.org/api/MS-CEINTL/vscode-language-pack-fr/1.53.2/file/MS-CEINTL.vscode-language-pack-fr-1.53.2.vsix",

"vscode-language-pack-zh-hans": "https://open-vsx.org/api/MS-CEINTL/vscode-language-pack-zh-hans/1.53.2/file/MS-CEINTL.vscode-language-pack-zh-hans-1.53.2.vsix",

"vscode-language-pack-de": "https://open-vsx.org/api/MS-CEINTL/vscode-language-pack-de/1.53.2/file/MS-CEINTL.vscode-language-pack-de-1.53.2.vsix",

"vscode-language-pack-ja":"https://open-vsx.org/api/MS-CEINTL/vscode-language-pack-ja/1.53.2/file/MS-CEINTL.vscode-language-pack-ja-1.53.2.vsix",

"vscode-language-pack-tr": "https://open-vsx.org/api/MS-CEINTL/vscode-language-pack-tr/1.53.2/file/MS-CEINTL.vscode-language-pack-tr-1.53.2.vsix"

}

Otherwise they will not be in the distribution package:
(削除ここまで)

(削除) image
(削除ここまで)