-
-
Notifications
You must be signed in to change notification settings - Fork 490
Fix remote sketchbook widget rendering empty #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@per1234
per1234
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Jun 23, 2022
@AlbyIanna
AlbyIanna
changed the title
(削除) Fix cloud sketchbook widget rendering empty (削除ここまで)
(追記) Fix remote sketchbook widget rendering empty (追記ここまで)
Jun 30, 2022
@AlbyIanna
AlbyIanna
force-pushed
the
remote-sketchbook-empty
branch
from
June 30, 2022 11:38
62a8fcd to
7684dbf
Compare
AlbyIanna
AlbyIanna
commented
Jun 30, 2022
...ino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-composite-widget.tsx
Outdated
Show resolved
Hide resolved
per1234
per1234
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kittaakos
kittaakos
approved these changes
Jul 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix; it looks good to me!
Please simplify the resize call with:
this.onResize(Widget.ResizeMessage.UnknownSize);
@AlbyIanna
AlbyIanna
force-pushed
the
remote-sketchbook-empty
branch
from
July 4, 2022 10:46
7684dbf to
cd1bb09
Compare
@per1234
per1234
added
the
topic: cloud
Related to Arduino Cloud and cloud sketches
label
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Motivation
Sometimes, the Remote Sketchbook content is empty. Clicking inside the widget content or resizing the sidebar will make the content appear.
Fixes #1129
Change description
Send a "fake" resize message to the cloud sketchbook tree to trigger a correct render.
Other information
Reviewer checklist