Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Sketchbook tree indentation #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francescospissu merged 1 commit into main from fspissu/sketchbook-indent
Jun 22, 2022
Merged

Conversation

Copy link
Contributor

@francescospissu francescospissu commented Jun 22, 2022
edited
Loading

Motivation

  • The indent size of the folders in the sketchbook is too small

The sketchbook structure:

Arduino/
├── Foo/
│ └── Bar/
│ └── Sketch/
│ └── Sketch_old/

was rendered:

folders_before

after the changes:

folders_after

  • The sketches have an inappropriate indentation level

The sketchbook structure:

Arduino/
├── Foo/
│ └── Bar/
│ └── sketch_jun14a/

was rendered:

sketch_before

after the changes:

sketch_after

Change description

Updated the left padding of the icons in the sketchbook

Other information

Fix for:

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #1050 and #1049 for me. It really does make it much easier to browse a complex sketchbook.

Thanks Francesco!

francescospissu reacted with hooray emoji
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 22, 2022
@kittaakos kittaakos self-requested a review June 22, 2022 15:17
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

francescospissu reacted with thumbs up emoji
@francescospissu francescospissu deleted the fspissu/sketchbook-indent branch June 22, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@fstasi fstasi Awaiting requested review from fstasi

+1 more reviewer

@kittaakos kittaakos kittaakos approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Sketchbook view, sketches are indented by the folder expansion control icon width even when there is no icon Increase Sketchbook view tree indent

AltStyle によって変換されたページ (->オリジナル) /