-
-
Notifications
You must be signed in to change notification settings - Fork 489
Sketchbook tree indentation #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@francescospissu
francescospissu
requested review from
kittaakos,
fstasi and
per1234
June 22, 2022 10:30
This was
linked to
issues
Jun 22, 2022
per1234
per1234
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@per1234
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Jun 22, 2022
arduino-ide-extension/src/browser/widgets/sketchbook/sketchbook-tree-widget.tsx
Show resolved
Hide resolved
kittaakos
kittaakos
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@francescospissu
francescospissu
force-pushed
the
fspissu/sketchbook-indent
branch
from
June 22, 2022 15:20
f4b2238
to
a0aa333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Motivation
The sketchbook structure:
was rendered:
folders_before
after the changes:
folders_after
The sketchbook structure:
was rendered:
sketch_before
after the changes:
sketch_after
Change description
Updated the left padding of the icons in the sketchbook
Other information
Fix for:
Reviewer checklist