Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Output panel optimisation #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davegarthsimpson merged 5 commits into main from 405-68-output-panel-optimization
Jun 14, 2022
Merged

Conversation

Copy link
Contributor

@davegarthsimpson davegarthsimpson commented Jun 13, 2022 •
edited
Loading

Motivation

Output panel prints slower than the CLI and on windows is out of sync with the upload operation.

Change description

Adds a simple buffer mechanism for the related stream from the CLI.

Other information

Optimisations on CLI side should also complement the resolution of this issue.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Copy link
Contributor

@per1234 per1234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the build from 085f97e and this fixes both #68 and #405 for me.

In order to do a more thorough test of #68, I replaced the standard upload tool command with a script that prints 10000 lines of text. That results in a large delay between the completion of the upload process and the completion of printing to the Output panel when using the latest build from the main branch. Using the build from this PR, the output printing completes at the same time as the upload process.

Thanks Dave!

davegarthsimpson reacted with hooray emoji
@davegarthsimpson davegarthsimpson requested review from kittaakos and removed request for kittaakos June 14, 2022 10:47
@davegarthsimpson davegarthsimpson deleted the 405-68-output-panel-optimization branch June 14, 2022 11:00
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

+1 more reviewer

@kittaakos kittaakos kittaakos left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slow compilation output throughput in "Output" panel Verbose upload output rate is very slow

AltStyle によって変換されたページ (->オリジナル) /