-
-
Notifications
You must be signed in to change notification settings - Fork 491
Bound the original handler to this.
#1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #977 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
francescospissu
francescospissu
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested the change and it now works as expected. No more errors are thrown when clicking anywhere in the IDE.
Arduino IDE version
2.0.0-rc7-snapshot-f30fa8e
Operating system
Windows 11
@per1234
per1234
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Motivation
To fix the error that occurred on every click in the IDE2.
Change description
bindthe original function tothis.Other information
It still should not be possible to drag and drop widgets.
How to verify the fix:
Ctrl+Alt+Ion Windows andOption+Cmd+Ion macOS),cannot read properties of undefined (reading '_evtMouseDown')error. If you do not know how to reproduce the defect, please check An error is thrown when I click in the editor, or output view #977 for inspiration.Closes #977
Reviewer checklist