-
-
Notifications
You must be signed in to change notification settings - Fork 489
Fix monitor service id creation #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstasi
fstasi
approved these changes
Jun 8, 2022
per1234
per1234
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue for me. Great work @AlbyIanna!
@per1234
per1234
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR solves an issue that happens when uploading a sketch to some boards when the serial port is open.
Some boards need configuration parameters to append to the fqbn during the upload:
https://github.com/arduino/arduino-ide/blob/main/arduino-ide-extension/src/browser/contributions/upload-sketch.ts#L216-L219
and this is messing up with the
MonitorManagerbecause whennotifyUploadStarted()is called, the monitor ID won't match theMonitorServiceinstance that handles the serial connection:https://github.com/arduino/arduino-ide/blob/main/arduino-ide-extension/src/node/monitor-manager.ts#L114-L119
Change description
Add some logic to make sure only the first part of an fqbn is relevant when creating a
monitorIDhttps://github.com/arduino/arduino-ide/compare/fix-monitor-id?expand=1#diff-cf90510ad3f811b7073a1934f11698463693bf446a2521eb2a55f27a48328427R218-R220
Other information
Reviewer checklist