-
-
Notifications
You must be signed in to change notification settings - Fork 489
Fixed LS stops working after OS sleep/wakeup cycle #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@ubidefeo
ubidefeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and works
I have first used RC6 to make sure that upon sleep (on Mac) it would fail to trigger code assist and then installed this build to do the same.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clever solution! should we propose this to theia? @kittaakos
should we propose this to theia? @kittaakos
I did: eclipse-theia/theia#11252. No interest. 🦗
Motivation
This PR should fix the unresponsive language feature after waking up the OS from sleep.
Change description
Theia does not fire an event when the connection to the plugin server proxy closes. Theia also does not fire an event if the hosted plugins have been re-loaded. This PR adds hooks for such events, and wires in the lifecycle of the LS to the new events exposed from the hosted plugins.
Other information
Steps to verify:
Reviewer checklist