Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Improved the IDE startup and new sketch creation time #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kittaakos merged 1 commit into main from startup-time-signed
Jun 7, 2022

Conversation

Copy link
Contributor

@kittaakos kittaakos commented Jun 1, 2022

Motivation

Change description

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Copy link

ubidefeo commented Jun 1, 2022

The feature seems to work well now when auto-save is disabled.
I have two remarks:

When we close a window (Sketch) or quit the IDE we should get two different messages.
Right now for any occurrence of unsaved change in one or more sketches we have the same message

Screenshot 2022年06月01日 at 15 15 37

This message should change based on the event.
Close sketch:
Are you sure you want to close this sketch?
Any unsaved changes will be lost

Quit IDE:
Are you sure you want to quit Arduino IDE?
Any unsaved changes will be lost


export default new ContainerModule((bind, unbind, isBound, rebind) => {
ElementQueries.listen();
ElementQueries.init();
Copy link
Contributor Author

@kittaakos kittaakos Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include in the changelog?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 not sure, why do you think is useful? I might be missing something

@kittaakos kittaakos force-pushed the startup-time-signed branch 4 times, most recently from 4e655e5 to 5b60cb4 Compare June 7, 2022 09:02 
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@fstasi fstasi self-requested a review June 7, 2022 11:37
@kittaakos kittaakos merged commit 4c55807 into main Jun 7, 2022
@kittaakos kittaakos deleted the startup-time-signed branch June 7, 2022 11:46
@per1234 per1234 linked an issue Jun 8, 2022 that may be closed by this pull request
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 9, 2022
@per1234 per1234 mentioned this pull request Jun 10, 2022
3 tasks
@per1234 per1234 changed the title (削除) Improved the IDE2 startup and new sketch creation time (削除ここまで) (追記) Improved the IDE startup and new sketch creation time (追記ここまで) Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

@per1234 per1234 Awaiting requested review from per1234

1 more reviewer

@fstasi fstasi fstasi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Takes x 6 times to load in compare to the old IDE

AltStyle によって変換されたページ (->オリジナル) /