-
-
Notifications
You must be signed in to change notification settings - Fork 50
Bump MrOctopus/download-asset-action from 1.0 to 1.1 #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MrOctopus/download-asset-action from 1.0 to 1.1 #66
Conversation
@per1234
per1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with the MrOctopus/download-asset-action action (MrOctopus/download-asset-action#8) that caused the CI failures at the time the PR was submitted has been fixed (MrOctopus/download-asset-action@d66a497), but the fact that a fundamentally broken release was made in the first place (indicating there is no validation/quality control of the action whatsoever), and then the way the fix was deployed (by moving the existing 1.1 tag instead of making a new tag) tells me that we should try to migrate away from using MrOctopus/download-asset-action if possible.
An approach for installing ClangFormat going forward will also need to be decided upon in arduino/tooling-project-assets#395.
per1234
commented
Aug 26, 2025
@dependabot rebase
Bumps [MrOctopus/download-asset-action](https://github.com/mroctopus/download-asset-action) from 1.0 to 1.1. - [Release notes](https://github.com/mroctopus/download-asset-action/releases) - [Commits](MrOctopus/download-asset-action@1.0...1.1) --- updated-dependencies: - dependency-name: MrOctopus/download-asset-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
50fdacc to
bf5a7eb
Compare
@per1234
per1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plan to migrate away from this action mentioned in the previous review still stands. However, since the new version of the action is perfectly functional for the purpose, and since clearly we are not able to complete that task in a timely fashion, it is best to just go ahead with the bump.
Uh oh!
There was an error while loading. Please reload this page.
Bumps MrOctopus/download-asset-action from 1.0 to 1.1.
Release notes
Sourced from MrOctopus/download-asset-action's releases.
Commits
175b1afUpdated package.json version to 1.1.0d81f005Updated node_modulesDependabot compatibility score
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)