-
-
Notifications
You must be signed in to change notification settings - Fork 49
Remove compilations that fail due to bugs in external components from "Compile Examples" CI workflow #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...y bugs in external components
The tone() function has not been implemented in the core library of the Due's "Arduino ARM (32-bits) Boards" platform. Should the day ever come when this standardized component of the Arduino API is provided for the Due, this commit should be reverted.
...workflow The pulseIn() function has not yet been implemented for the Portenta H7 boards in the core library of their "Arduino Mbed OS Boards (nRF52840 / STM32H747)" platform. Once the pulseIn() function has been implemented for Portenta H7 and a release of the platform made containing that implementation, this commit should be reverted.
CI didn't run on this PR due to the repository being private, but you can see it here:
https://github.com/per1234/arduino-examples/actions/runs/237564235
You can see that all CI jobs are now passing.
rsora
rsora
approved these changes
Sep 3, 2020
@rsora
rsora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding!
Excellent job @per1234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common functions of the standardized Arduino core API used by the example sketches have not been implemented in the core libraries of for some of the active official boards the Compile Examples workflow tests compilation of the example sketches for.
pulseIn()missing for Portenta H7 ("undefined reference" when compiling sketches that use pulseIn() for Portenta H7 boards ArduinoCore-mbed#48 )tone()missing for Due (enabling Tone for Due ArduinoCore-sam#24 )Once these functions have been implemented and a release of the platform made containing that implementation, the commits removing the compillations should be reverted.
This procedure is documented in a comment at the top of the Compile Examples workflow configuration file.