-
-
Notifications
You must be signed in to change notification settings - Fork 49
Update AnalogReadSerial.ino #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed faulty link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please, please, please also set up redirects for these URLs. I'm sure thousands of links to the previous URL all over the Internet were broken by the change that caused this to be necessary.
@ubidefeo there was a change to the structure of the documentation content on arduino.cc that changed URLs. Some of the old URLs were not redirected, which was the case with http://www.arduino.cc/en/Tutorial/AnalogReadSerial, which was likely the motivation for this PR.
I see that now http://www.arduino.cc/en/Tutorial/AnalogReadSerial does redirect as it should to the new URL https://www.arduino.cc/en/Tutorial/BuiltInExamples/AnalogReadSerial (thanks!), but I think it's still a good idea to update this URL to point to the new location of the content to avoid relying on the redirect. The same issue occurs in every single example in this repository.
@ubidefeo I'll do that.
I'll do that.
Forget about it. I went ahead and did it. Please review: #30
Fixed faulty link