Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[skip changelog] document the docs generation workflow #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsora merged 3 commits into master from massi/document-docs
Jun 10, 2020

Conversation

Copy link
Contributor

@masci masci commented Jun 3, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

It adds better documentation around the process we use to generated the documentation website at https://arduino.github.io/arduino-cli/

  • What is the current behavior?

Current documentation on the topic is incomplete and slightly incorrect/outdated.

  • What is the new behavior?

Any aspect of the process of generating docs for different versions of the Arduino CLI has been detailed.

  • Does this PR introduce a breaking change?

No changes to the CLI.

  • Other information:

These docs are intended for CLI developers, not CLI users, so I've just expanded CONTRIBUTING.md but this is completely arbitrary, happy to move them to a better location if needed.


See how to contribute

@masci masci added the topic: documentation Related to documentation for the project label Jun 3, 2020
@masci masci requested review from per1234 and rsora June 3, 2020 16:06

Before we can accept your contributions you have to sign the [Contributor License Agreement][0]

## Pull Requests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but I thought this paragraph should be upper in the page as it's more human-related than technical.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @masci!

I only have some minor nitpicky suggestions for you.

masci reacted with heart emoji
Co-authored-by: per1234 <accounts@perglass.com>
@rsora rsora merged commit ae179cf into master Jun 10, 2020
@rsora rsora deleted the massi/document-docs branch June 10, 2020 17:10
umbynos pushed a commit that referenced this pull request Jun 17, 2020
* [skip changelog] document the docs generation workflow
* clarify how humans should not push to gh-pages
* Apply suggestions from code review
Co-authored-by: per1234 <accounts@perglass.com>
Co-authored-by: per1234 <accounts@perglass.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@rsora rsora Awaiting requested review from rsora

Assignees
No one assigned
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /