-
-
Notifications
You must be signed in to change notification settings - Fork 422
Remove unused "verbose" field from gRPC Debug service request message #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,8 +53,7 @@ message DebugConfigReq { | |
| string sketch_path = 3; | ||
| string port = 4; | ||
| string interpreter = 5; | ||
| bool verbose = 6; | ||
| string import_file = 7; | ||
| string import_file = 6; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's ok to remove a field but do not change the numeric identifier of existing fields like in: - string import_file = 7; + string import_file = 6; this provides a better backward compatibility (well, at least the "verbose" value won't go into "import_file" when using an old client). I'll fixi it while rebasing #687 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the information. I was following #689 as a reference, but without really knowing what I was doing. |
||
| } | ||
|
|
||
| // | ||
|
|
||