-
-
Notifications
You must be signed in to change notification settings - Fork 422
Added 'board details' #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just tested this on esp8266:esp8266:generic board.
There are some options without label (did not parsed well) for upload speed on different OS:
Option: Upload Speed UploadSpeed
115200 ✔ UploadSpeed=115200
9600 UploadSpeed=9600
57600 UploadSpeed=57600
230400 UploadSpeed=230400
UploadSpeed=256000
460800 UploadSpeed=460800
UploadSpeed=512000
921600 UploadSpeed=921600
Cause boards.txt contains:
generic.menu.UploadSpeed.115200=115200
generic.menu.UploadSpeed.115200.upload.speed=115200
generic.menu.UploadSpeed.9600=9600
generic.menu.UploadSpeed.9600.upload.speed=9600
generic.menu.UploadSpeed.57600=57600
generic.menu.UploadSpeed.57600.upload.speed=57600
generic.menu.UploadSpeed.230400.linux=230400
generic.menu.UploadSpeed.230400.macosx=230400
generic.menu.UploadSpeed.230400.upload.speed=230400
generic.menu.UploadSpeed.256000.windows=256000
generic.menu.UploadSpeed.256000.upload.speed=256000
generic.menu.UploadSpeed.460800.linux=460800
generic.menu.UploadSpeed.460800.macosx=460800
generic.menu.UploadSpeed.460800.upload.speed=460800
generic.menu.UploadSpeed.512000.windows=512000
generic.menu.UploadSpeed.512000.upload.speed=512000
generic.menu.UploadSpeed.921600=921600
generic.menu.UploadSpeed.921600.upload.speed=921600
output/table.go
Outdated
for x := range average {
average[x] = average[x] / count[x]
}
// fmt.Println("COUNT:", count)
@brusherru
brusherru
Oct 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale code for debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
brusherru
commented
Oct 15, 2018
Overall, awesome! 🙌
@cmaglie
cmaglie
force-pushed
the
board-details
branch
from
October 19, 2018 10:49
11441d0 to
6fdf4f5
Compare
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Oct 19, 2018
See: arduino#67 (comment) quote: There are some options without label (did not parsed well) for upload speed on different OS: Option: Upload Speed UploadSpeed 115200 ✔ UploadSpeed=115200 9600 UploadSpeed=9600 57600 UploadSpeed=57600 230400 UploadSpeed=230400 UploadSpeed=256000 460800 UploadSpeed=460800 UploadSpeed=512000 921600 UploadSpeed=921600 Cause boards.txt contains: generic.menu.UploadSpeed.115200=115200 generic.menu.UploadSpeed.115200.upload.speed=115200 generic.menu.UploadSpeed.9600=9600 generic.menu.UploadSpeed.9600.upload.speed=9600 generic.menu.UploadSpeed.57600=57600 generic.menu.UploadSpeed.57600.upload.speed=57600 generic.menu.UploadSpeed.230400.linux=230400 generic.menu.UploadSpeed.230400.macosx=230400 generic.menu.UploadSpeed.230400.upload.speed=230400 generic.menu.UploadSpeed.256000.windows=256000 generic.menu.UploadSpeed.256000.upload.speed=256000 generic.menu.UploadSpeed.460800.linux=460800 generic.menu.UploadSpeed.460800.macosx=460800 generic.menu.UploadSpeed.460800.upload.speed=460800 generic.menu.UploadSpeed.512000.windows=512000 generic.menu.UploadSpeed.512000.upload.speed=512000 generic.menu.UploadSpeed.921600=921600 generic.menu.UploadSpeed.921600.upload.speed=921600
There are some options without label (did not parsed well) for upload speed on different OS:
nice catch! This latest update should fix it, let's wait the CI to merge...
This allows to show which option is selected with defaults or with different FQBNs. For example: $ arduino-cli board details arduino:avr:nano Board name: Arduino Nano Option: Processor cpu ATmega328P ✔ cpu=atmega328 ATmega328P (Old Bootloader) cpu=atmega328old ATmega168 cpu=atmega168 or: $ arduino-cli board details arduino:avr:nano:cpu=atmega328old Board name: Arduino Nano Option: Processor cpu ATmega328P cpu=atmega328 ATmega328P (Old Bootloader) ✔ cpu=atmega328old ATmega168 cpu=atmega168
See: arduino#67 (comment) quote: There are some options without label (did not parsed well) for upload speed on different OS: Option: Upload Speed UploadSpeed 115200 ✔ UploadSpeed=115200 9600 UploadSpeed=9600 57600 UploadSpeed=57600 230400 UploadSpeed=230400 UploadSpeed=256000 460800 UploadSpeed=460800 UploadSpeed=512000 921600 UploadSpeed=921600 Cause boards.txt contains: generic.menu.UploadSpeed.115200=115200 generic.menu.UploadSpeed.115200.upload.speed=115200 generic.menu.UploadSpeed.9600=9600 generic.menu.UploadSpeed.9600.upload.speed=9600 generic.menu.UploadSpeed.57600=57600 generic.menu.UploadSpeed.57600.upload.speed=57600 generic.menu.UploadSpeed.230400.linux=230400 generic.menu.UploadSpeed.230400.macosx=230400 generic.menu.UploadSpeed.230400.upload.speed=230400 generic.menu.UploadSpeed.256000.windows=256000 generic.menu.UploadSpeed.256000.upload.speed=256000 generic.menu.UploadSpeed.460800.linux=460800 generic.menu.UploadSpeed.460800.macosx=460800 generic.menu.UploadSpeed.460800.upload.speed=460800 generic.menu.UploadSpeed.512000.windows=512000 generic.menu.UploadSpeed.512000.upload.speed=512000 generic.menu.UploadSpeed.921600=921600 generic.menu.UploadSpeed.921600.upload.speed=921600
Race conditions tests are run on another CI system, before releases.
@cmaglie
cmaglie
force-pushed
the
board-details
branch
from
October 19, 2018 12:08
61f75df to
43bcb84
Compare
✅ Build completed.
⬇️ Linux 64: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-16-PR67-linux64.tar.bz2
⬇️ Linux 32: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-16-PR67-linux32.tar.bz2
⬇️ Linux ARM: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-16-PR67-linuxarm.tar.bz2
⬇️ Windows: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-16-PR67-windows.zip
⬇️ OSX: http://downloads.arduino.cc/PR/arduino-cli/arduino-cli-16-PR67-osx.zip
i️ To test this build:
- Just replace
arduino-clibinary with the provided one
brusherru
brusherru
approved these changes
Oct 19, 2018
@brusherru
brusherru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 👍
mastrolinux
pushed a commit
that referenced
this pull request
Jul 16, 2019
See: #67 (comment) quote: There are some options without label (did not parsed well) for upload speed on different OS: Option: Upload Speed UploadSpeed 115200 ✔ UploadSpeed=115200 9600 UploadSpeed=9600 57600 UploadSpeed=57600 230400 UploadSpeed=230400 UploadSpeed=256000 460800 UploadSpeed=460800 UploadSpeed=512000 921600 UploadSpeed=921600 Cause boards.txt contains: generic.menu.UploadSpeed.115200=115200 generic.menu.UploadSpeed.115200.upload.speed=115200 generic.menu.UploadSpeed.9600=9600 generic.menu.UploadSpeed.9600.upload.speed=9600 generic.menu.UploadSpeed.57600=57600 generic.menu.UploadSpeed.57600.upload.speed=57600 generic.menu.UploadSpeed.230400.linux=230400 generic.menu.UploadSpeed.230400.macosx=230400 generic.menu.UploadSpeed.230400.upload.speed=230400 generic.menu.UploadSpeed.256000.windows=256000 generic.menu.UploadSpeed.256000.upload.speed=256000 generic.menu.UploadSpeed.460800.linux=460800 generic.menu.UploadSpeed.460800.macosx=460800 generic.menu.UploadSpeed.460800.upload.speed=460800 generic.menu.UploadSpeed.512000.windows=512000 generic.menu.UploadSpeed.512000.upload.speed=512000 generic.menu.UploadSpeed.921600=921600 generic.menu.UploadSpeed.921600.upload.speed=921600
per1234
added a commit
that referenced
this pull request
Aug 9, 2021
Add checks for common misspellings of path base names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should partially (or even totally) fix #45.
examples of output:
/cc @brusherru