-
-
Notifications
You must be signed in to change notification settings - Fork 422
Add support for compile with debug optimizations #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rsora
rsora
force-pushed
the
rsora/debug-compile
branch
from
February 21, 2020 16:22
33971be to
4683706
Compare
cmaglie
cmaglie
approved these changes
Feb 21, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #590 And adds support for compile with debug optimization via CLI flag or gRPC message field.
If a core exposes a
compiler.optimization_flagsand acompiler.optimization_flags.debugproperties for the compile recipe, using:--optimize-for-debugin acompilecommandor
CompileReq.optimizeForDebug = Truein gRPC modethe CLI sketch builder replaces standard compiler optimization flags with debug optimized ones, generating a "debugger friendly" sketch.
legacytesting was fixed accordinglyNOTE:
This modification caused to modify slightly the core caching folder generation process:
The CLI caches the compiled core for a sketch to improve compile performances.
To cache correctly a core built with (or without) debug optimization option, the compiled core saving process on disk must save the artifact in a different folder respect to the not debug optimized version.
The cached core reused process has also to fetch the core accordingly, during following compile iterations.