Skip to content

Added better error handling for the gRPC server. #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

masci merged 1 commit into arduino:master from kittaakos:daemon-exit-code

Feb 21, 2020

Merged

Added better error handling for the gRPC server. #592

masci merged 1 commit into arduino:master from kittaakos:daemon-exit-code

Feb 21, 2020

Conversation

Copy link

Contributor

@kittaakos kittaakos commented Feb 21, 2020

Consumers of the CLI have a better exit code when it fails at startup
Logged message to stdout, so gRPC clients know, it is time to connect

Signed-off-by: Akos Kitta kittaakos@typefox.io

@kittaakos kittaakos force-pushed the daemon-exit-code branch from 894406e to 847edc3 Compare

February 21, 2020 13:35

masci suggested changes

View reviewed changes

cli/daemon/daemon.go Outdated

// Invalid port, such as "Foo"

var dnsError *net.DNSError

if errors.As(err, &dnsError) {

logrus.Errorf("Failed to listen on TCP port: %s. %s is unknown name.", port, dnsError.Name)

Copy link

Contributor

@masci masci Feb 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do feedback.Errorf instead? This way the error will be always visible in the shell, not regarding of passing -v and will be added to the logs as well. Same for other occurrences of logrus.*

Copy link

Contributor Author

@kittaakos kittaakos Feb 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback. I have made the changes based on your request and left the original logrus.Fatalf("failed to serve: %v", err) as is.

@masci masci added the component/CLI label

@masci masci added this to the 0.9.0 milestone


 Added better error handling for the gRPC server.

dfafb49

 - Consumers of the CLI have a better exit code when it fails at startup
 - Logged message to stdout, so gRPC clients know, it is time to connect
Signed-off-by: Akos Kitta <kittaakos@typefox.io>

@kittaakos kittaakos force-pushed the daemon-exit-code branch from 847edc3 to dfafb49 Compare

February 21, 2020 14:17

masci approved these changes

View reviewed changes

@masci masci merged commit 1eefe49 into arduino:master

@kittaakos kittaakos deleted the daemon-exit-code branch

February 21, 2020 15:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@kittaakos @masci