-
-
Notifications
You must be signed in to change notification settings - Fork 422
Fix library priority selection #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cmaglie
merged 4 commits into
arduino:master
from
cmaglie:fix-library-priority-selection
Jan 23, 2020
Merged
Fix library priority selection #565
cmaglie
merged 4 commits into
arduino:master
from
cmaglie:fix-library-priority-selection
Jan 23, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is used only in library resolver, there is not point in having it as method of Library. Removed also the unused SortByArchitecturePriority method.
facchinm
facchinm
approved these changes
Jan 23, 2020
cmaglie
added a commit
to arduino/arduino-builder
that referenced
this pull request
Jan 23, 2020
Fix library priority selection - arduino/arduino-cli#565 Load contents of source files only when needed - arduino/arduino-cli#559 Allow naming sketches like "RCS" and "CVS" - arduino/arduino-cli#537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the priority rules.
Should fix arduino/Arduino#9655