-
-
Notifications
You must be signed in to change notification settings - Fork 422
Add cache clean command #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I should appending test case in this PR right?
@howjmay
howjmay
force-pushed
the
cache_clean
branch
3 times, most recently
from
January 18, 2020 13:54
f31958e to
c8b1d9b
Compare
masci
masci
suggested changes
Jan 20, 2020
@masci
masci
changed the title
(削除) feat: Add cache clean (削除ここまで)
(追記) Add cache clean command (追記ここまで)
Jan 20, 2020
@howjmay
howjmay
force-pushed
the
cache_clean
branch
from
January 21, 2020 12:07
c8b1d9b to
d99c7c4
Compare
Fixed it
Add command `cache clean` to clean the cache files depending on the loaction of the caching files under different OS.
Clean cache files with command `arduino-cli cache clean`.
@masci
masci
force-pushed
the
cache_clean
branch
from
February 4, 2020 14:43
19fbd34 to
8709857
Compare
masci
masci
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures are unrelated.
I've simplified a bit the logic of the tests leveraging pytest fixtures, other than that LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command
cache cleanto clean the cache filesdepending on the loaction of the caching files
under different OS.
Relates #285