-
-
Notifications
You must be signed in to change notification settings - Fork 423
[skip changelog] Demonstrate the use of the gRPC Settings interface in client_example #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@andmeyee I've updated client_example as you requested. If you have some time, have a look and let me know if you have any suggestions for improvement.
...n client_example - Demonstrate SetValue, Merge, GetValue, and GetAll. - Switch from the deprecated configuration request field of Init to using the Settings service to configure arduino-cli's directories.
andmeyee
commented
Jan 13, 2020
@per1234 thanks for the update. From what I can see in the code everything looks good. But I have to say that I have currently no go runtime installed and am therefore not able to run the code and see if it is fully working. But if you like I can give it a try within the next days.
Using the same gRPC calls from Python is working as expected.
Hi @andmeyee thanks for taking a look at it. Don't feel obligated to set up Go just for this, but if you want to, it would be welcome. I was mostly interested in getting your feedback on whether this change provides a clear example of how to use the Settings interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton, I completely forgot to update the example 🙇♂️
SetValue,Merge,GetValue, andGetAll(added in Add gRPC interface to CLI settings #521 ).configurationrequest field ofInitto using theSettingsservice to configure arduino-cli's directories.As requested at #553 (comment)