Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[skip changelog] [skip ci] Clarify additional-urls option usage #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsora merged 3 commits into master from rsora/additional-urls-doc
Jan 9, 2020

Conversation

Copy link
Contributor

@rsora rsora commented Jan 9, 2020

This PR propose the usage of the config file option as best mode for 3rd party core usage.

The --additional-urls flag is now presented as an alternative, adding a complete usage explanation.

@rsora rsora added the topic: documentation Related to documentation for the project label Jan 9, 2020
README.rst Outdated
esp8266:esp8266 2.5.2 esp8266
Alternatively you can pass a link to the the additional package index file with the ``--additional-urls`` option to
every command that require a platform core to work:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/require/requires

README.rst Outdated
ID Version Name
esp8266:esp8266 2.5.2 esp8266
Alternatively you can pass a link to the the additional package index file with the ``--additional-urls`` option to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could stress the fact that you always have to pass the option if you decide to not use the config file, something on these lines:

Alternatively, you can pass a link to the the additional package index file with the --additional-urls option, but this has to be done every time and for every command that operates on a platform core, for example:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I have rephrased it a bit, please check if it makes sense.

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@masci masci masci approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /