-
-
Notifications
You must be signed in to change notification settings - Fork 422
GRPC serial monitor: Fix unhandled error (EINTR) that leaves serial port open
#507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Includes a fix to serial.Read method. Should fix: arduino#504 Actual patch: bugst/go-serial#69
I am trying it right now and will use this version of CLI for arduino/arduino-pro-ide#112. I will update this PR if I find any issues.
Thank you for your help, @cmaglie!
After looking into the changeset; I would have expected a mon.Close() here. But let me verify it first...
I would have expected a
mon.Close()here.
I haven't experienced any issues, will be doing additional verifications during the development tomorrow. Very very promising fix 🙏
@cmaglie, I have been using this version of CLI since yesterday and haven't had any issues with it. Awesome 🎉, +1 for merging it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kittaakos for testing!
Update go-serial library to latest version, includes a fix to serial.Read method.
Should fix: #504
Actual patch: bugst/go-serial#69
@kittaakos