Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Make integration-test independent from current libraries version #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmaglie wants to merge 1 commit into arduino:master
base: master
Choose a base branch
Loading
from cmaglie:fix-ci

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 17, 2025

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fix some integration tests.

What is the current behavior?

CI Fails:

 profile_lib_commands_test.go:359: 
 	Error Trace:	/home/runner/work/arduino-cli/arduino-cli/internal/integrationtest/daemon/profile_lib_commands_test.go:359
 	Error: 	Not equal: 
 	 	expected: []*commands.ProfileLibraryReference{(*commands.ProfileLibraryReference)(0xc0004d6500), (*commands.ProfileLibraryReference)(0xc0004d6540), (*commands.ProfileLibraryReference)(0xc0004d6580), (*commands.ProfileLibraryReference)(0xc0004d65c0), (*commands.ProfileLibraryReference)(0xc0004d6600), (*commands.ProfileLibraryReference)(0xc0004d6640)}
 	 	actual : []*commands.ProfileLibraryReference{(*commands.ProfileLibraryReference)(0xc0004d62c0), (*commands.ProfileLibraryReference)(0xc0004d6300), (*commands.ProfileLibraryReference)(0xc0004d6380), (*commands.ProfileLibraryReference)(0xc0004d63c0), (*commands.ProfileLibraryReference)(0xc0004d6440), (*commands.ProfileLibraryReference)(0xc0004d64c0)}
 	 	
 	 	Diff:
 	 	--- Expected
 	 	+++ Actual
 	 	@@ -27,3 +27,3 @@
 	 	 Name: (string) (len=15) "Arduino_RPClite",
 	 	- Version: (string) (len=5) "0.2.0",
 	 	+ Version: (string) (len=5) "0.2.1",
 	 	 IsDependency: (bool) true
 	Test: 	TestProfileLibRemoveWithDeps
 --- FAIL: TestProfileLibRemoveWithDeps (12.33s)

What is the new behavior?

CI Pass.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie self-assigned this Dec 17, 2025
@cmaglie cmaglie added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Dec 17, 2025
@cmaglie cmaglie requested a review from a team December 17, 2025 20:44
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.49%. Comparing base (f122326) to head (7a1c2ef).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@ Coverage Diff @@
## master #3069 +/- ##
==========================================
- Coverage 69.50% 69.49% -0.02% 
==========================================
 Files 253 253 
 Lines 19172 19172 
==========================================
- Hits 13326 13323 -3 
- Misses 4616 4617 +1 
- Partials 1230 1232 +2
Flag Coverage Δ
unit 69.49% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /