Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Taskfile cache-dep-license will update also deb package license recap #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmaglie wants to merge 3 commits into arduino:master
base: master
Choose a base branch
Loading
from cmaglie:task-file-improve

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 1, 2025 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Running task general:cache-dep-licenses will automatically update the deb package license recap in one go.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Copy link
Contributor

@per1234 per1234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change renders this workflow step obsolete:

- name: Check debian copyright file
run: |
task update-deb-copyright
git diff --color --exit-code

(since an out of sync copyright file will now be caught by the "Check for outdated cache" step in the workflow)

So the unnecessary step should be removed from the workflow to avoid unnecessary clutter and maintenance burden.

debian/arduino-cli/usr/share/doc/arduino-cli/copyright should be added to the paths filters of the "Check Go Dependencies" workflow:

push:
paths:
- ".github/workflows/check-go-dependencies-task.ya?ml"
- ".licenses/**"
- ".licensed.json"
- ".licensed.ya?ml"
- "Taskfile.ya?ml"
- "**/.gitmodules"
- "**/go.mod"
- "**/go.sum"
pull_request:
paths:
- ".github/workflows/check-go-dependencies-task.ya?ml"
- ".licenses/**"
- ".licensed.json"
- ".licensed.ya?ml"
- "Taskfile.ya?ml"
- "**/.gitmodules"
- "**/go.mod"
- "**/go.sum"

@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Sep 1, 2025
@cmaglie cmaglie self-assigned this Nov 14, 2025
Copy link
Member Author

cmaglie commented Nov 14, 2025

Thanks @per1234 I've applied the suggestions.

Copy link

codecov bot commented Nov 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.33%. Comparing base (a86947b) to head (4db4308).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@ Coverage Diff @@
## master #2991 +/- ##
==========================================
- Coverage 69.34% 69.33% -0.02% 
==========================================
 Files 241 241 
 Lines 18590 18590 
==========================================
- Hits 12891 12889 -2 
- Misses 4503 4504 +1 
- Partials 1196 1197 +1
Flag Coverage Δ
unit 69.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 per1234 requested changes

Requested changes must be addressed to merge this pull request.

Labels

topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /