-
-
Notifications
You must be signed in to change notification settings - Fork 422
Fixed integration test runner #2986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
added
topic: infrastructure
Related to project infrastructure
type: imperfection
Perceived defect in any part of project
labels
Aug 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #2986 +/- ## ========================================== + Coverage 68.26% 68.29% +0.02% ========================================== Files 241 241 Lines 22703 22703 ========================================== + Hits 15499 15505 +6 + Misses 6007 6003 -4 + Partials 1197 1195 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mirkoCrobu
mirkoCrobu
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Should fix some sporadic
<<< stderr copy error: read |0: file already closederrors.What is the current behavior?
copy error: read |0: file already closedpops up randomly. This is probably due to the incorrectWaithappening before theio.Copynaturally terminates.What is the new behavior?
The
runsubroutines wait for theio.Copycompletion before callingWaiton the running process.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information