Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

commands: use the new endpoint to detect boards #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alessio-perugini merged 3 commits into master from boards-api-use-new-endpoints
Aug 12, 2025

Conversation

Copy link
Contributor

@alessio-perugini alessio-perugini commented Aug 12, 2025 •
edited by cmaglie
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Use the new endpoint we have created some months ago, to retrieve board information.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Aug 12, 2025
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@3eecf20). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
commands/service_board_identify.go 95.23% 1 Missing ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## master #2974 +/- ##
=========================================
 Coverage ? 68.24% 
=========================================
 Files ? 241 
 Lines ? 22703 
 Branches ? 0 
=========================================
 Hits ? 15493 
 Misses ? 6011 
 Partials ? 1199
Flag Coverage Δ
unit 68.24% <95.23%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alessio-perugini alessio-perugini marked this pull request as ready for review August 12, 2025 11:28
Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@alessio-perugini alessio-perugini merged commit 461b668 into master Aug 12, 2025
274 of 275 checks passed
@alessio-perugini alessio-perugini deleted the boards-api-use-new-endpoints branch August 12, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /