-
-
Notifications
You must be signed in to change notification settings - Fork 424
Do not use crossbuild container when CGO=0 #2943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alessio-perugini
alessio-perugini
added
the
topic: build-process
Related to the sketch build process
label
Jul 3, 2025
@cmaglie
cmaglie
added
type: enhancement
Proposed improvement
topic: infrastructure
Related to project infrastructure
and removed
topic: build-process
Related to the sketch build process
labels
Jul 4, 2025
cmaglie
cmaglie
approved these changes
Jul 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We should consider creating a more generic DistTask file template where CGO builds can be enabled with settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Golang supports cross-building by default. With this PR I propose not to use the crossbuild container of Elastic, when we are building without cgo. This will make our build process faster, and we minimize the dependency on Elastic Container at the bare minimum.
The trigger of this PR is that Elastic seem to have broke the manifest of arm images, and we are now blocked by bumping our go version.
What is the current behavior?
We are always using the elastic crossbuild container
What is the new behavior?
When building without CGO use native golang cross build capabilities
Does this PR introduce a breaking change, and is titled accordingly?
Other information