Some bugfix in profile parsing / Better support for platforms having tools dependencies on other platforms. #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cmaglie merged 5 commits into arduino:master from cmaglie:some-bugfix

Jul 3, 2025

Merged

Some bugfix in profile parsing / Better support for platforms having tools dependencies on other platforms. #2942

cmaglie merged 5 commits into arduino:master from cmaglie:some-bugfix

Jul 3, 2025

+414 −330

Conversation

cmaglie

Copy link

Member

@cmaglie cmaglie commented Jul 3, 2025

Please check if the PR fulfills these requirements

See how to contribute

The PR has no duplicates (please search among the Pull Requests
before creating one)
The PR follows
our contributing guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
UPGRADING.md has been updated with a migration guide (for breaking changes)
configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fix a profile sketch.yml rendering bug.
Fix a bug that prevents extracting all the needed information in installed.json.

What is the current behavior?

It will print an empty libraries: YAML object when the profile has no libraries. This is invalid YAML.
If the installed platform depends on a tool from another platform, the tool metadata is not extracted in the installed.json file. This would eventually make the platform unusable if the original index is removed.

What is the new behavior?

The libraries: field is not printed if there are no libraries in the profile.
The installed.json now has all the necessary metadata.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

cmaglie added 5 commits

July 3, 2025 14:19

@cmaglie


 Do not output empty 'libraries:' field if not needed in sketch.yaml

db1e1f9

@cmaglie


 Slightly refactored IndexFromPlatformRelease function

4ef9bbe

This will help to simplify the next commits.

@cmaglie


 Extract also referenced platform tools in installed.json.

10358c0

If a platform requires tools from another referenced platform, we must
extract the relevant data in the `installed.json` file too.

@cmaglie


 Refactoring unit-test

7e7d49d

Just moving code, no semantic change.
Helps to get the following commit cleaner.

@cmaglie


 Added unit-test

5e15ea3

@cmaglie cmaglie self-assigned this

Jul 3, 2025

@cmaglie cmaglie added topic: code type: imperfection labels

Jul 3, 2025

@codecov Codecov

Copy link

codecov bot commented Jul 3, 2025 •

edited

Loading

Codecov Report

Attention: Patch coverage is 95.06173% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.89%. Comparing base (4891ded) to head (5e15ea3).
Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/arduino/cores/packageindex/index.go	94.66%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@
## master #2942 +/- ##
==========================================
+ Coverage 67.82% 67.89% +0.07% 
==========================================
 Files 238 238 
 Lines 22460 22489 +29 
==========================================
+ Hits 15234 15270 +36 
+ Misses 6023 6019 -4 
+ Partials 1203 1200 -3