-
-
Notifications
You must be signed in to change notification settings - Fork 422
Use BoardsManifest if Boards is not applicable
#294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA assistant check
All committers have signed the CLA.
e4bd962 to
f204bfb
Compare
I am not sure this will work at all, I would have expected, names are unique, but it's not the case. I can see the following board names on my client:
Screen Shot 2019年07月22日 at 14 01 48
It's because both the arduino:samd_beta@1.6.25 and arduino:samd@1.8.3 platform releases contain the same Arduino MKR Vidor 4000 board.
This is certainly somewhat unexpected, but I'd think it depends on the use-case where this board list is used. In case of the board manager for example, after de-duping the list it would certainly be useful.
@masci what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is clear and well commented so I'm not concerned for having this workaround in the codebase. I think we should merge this while elaborating a fix for the root cause of #277.
@32leaves agree, that problem must be solved upstream, if deduping works for you in the meantime and it's helpful for the user (which I believe it's the case) we should go for it.
Code is clear and well commented
There is a typo, let me fix that now.
f204bfb to
fad37bb
Compare
let me fix that now.
Done.
fad37bb to
e068cc5
Compare
@ArduinoBot build this please
1 similar comment
@ArduinoBot build this please
✅ Build completed.
⬇️ Linux 64: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-148-PR294-linux64.tar.bz2
⬇️ Linux 32: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-148-PR294-linux32.tar.bz2
⬇️ Linux ARM: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-148-PR294-linuxarm.tar.bz2
⬇️ Windows: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-148-PR294-windows.zip
⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-148-PR294-osx.zip
i️ To test this build:
- Just replace
arduino-clibinary with the provided one
⬇️ OSX:
https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-148-PR294-osx.zip
Dear @ArduinoBot, the download link for macOS incorrect 😉
_ _ _ _ _
| | | | | | | | (_)
__| | _____ ___ __ | | ___ __ _ __| |___ __ _ _ __ __| |_ _ _ _ __ ___ ___ ___
/ _` |/ _ \ \ /\ / | '_ \| |/ _ \ / _` |/ _` / __| / _` | '__/ _` | | | | | '_ \ / _ \ / __/ __|
| (_| | (_) \ V V /| | | | | (_) | (_| | (_| \__ \_ | (_| | | | (_| | |_| | | | | | (_) | | (_| (__
\__,_|\___/ \_/\_/ |_| |_|_|\___/ \__,_|\__,_|___(_) \__,_|_| \__,_|\__,_|_|_| |_|\___/ (_\___\___|
Should end with -macosx.zip.
@ArduinoBot build this please
✅ Build completed.
⬇️ Linux 64: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-149-PR294-linux64.tar.bz2
⬇️ Linux 32: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-149-PR294-linux32.tar.bz2
⬇️ Linux ARM: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-149-PR294-linuxarm.tar.bz2
⬇️ Windows: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-149-PR294-windows.zip
⬇️ OSX: https://downloads.arduino.cc/PR/arduino-cli/arduino-cli-149-PR294-macosx.zip
i️ To test this build:
- Just replace
arduino-clibinary with the provided one
@kittaakos good catch!
Now the link is fixed.
@kittaakos can you rebase on master (again, sorry), the CI should pass then 🙇♂️
This patch falls back to the `BoardsManifest` when the `Boards` is not available. When the `Boards` are not installed, hence unavailable, the produced gRPC instance won't contain the `FQBN` but the `Name` only. Signed-off-by: Akos Kitta <kittaakos@typefox.io>
e068cc5 to
a48664b
Compare
The builds are green now.
This patch falls back to the
BoardsManifestwhen theBoardsis notavailable.
When the
Boardsare not installed, hence unavailable, the producedgRPC instance won't contain the
FQBNbut theNameonly.This patch is a kind of a workaround for #277. The name of the boards will be still available, although the
FQBNcannot be accessed.Let me know what you think about this patch. Thanks!
Signed-off-by: Akos Kitta kittaakos@typefox.io