Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Improve error code when platform not available for OS #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Contributor

@alessio-perugini alessio-perugini commented Jun 11, 2025 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Closes #2932

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

per1234 reacted with heart emoji
@alessio-perugini alessio-perugini added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 11, 2025
@alessio-perugini alessio-perugini changed the title (削除) arduino: improve error code when platform not available for OS (削除ここまで) (追記) Improve error code when platform not available for OS (追記ここまで) Jun 11, 2025
Copy link

codecov bot commented Jun 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.84%. Comparing base (2947cfb) to head (40ea05e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
commands/cmderrors/cmderrors.go 33.33% 4 Missing ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## master #2933 +/- ##
=======================================
 Coverage 67.84% 67.84% 
=======================================
 Files 238 238 
 Lines 22442 22450 +8 
=======================================
+ Hits 15226 15232 +6 
- Misses 6014 6017 +3 
+ Partials 1202 1201 -1
Flag Coverage Δ
unit 67.84% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alessio-perugini alessio-perugini force-pushed the 2932-confusing-error-when-platform-installation-fails-due-to-unavailable-tool branch from 58696a0 to 40ea05e Compare June 12, 2025 07:49
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alessio!

@alessio-perugini alessio-perugini merged commit 11b2625 into master Jun 12, 2025
203 checks passed
@alessio-perugini alessio-perugini deleted the 2932-confusing-error-when-platform-installation-fails-due-to-unavailable-tool branch June 12, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing error when platform installation fails due to unavailable tool

AltStyle によって変換されたページ (->オリジナル) /