Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Expose Dependencies field in Library struct #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alessio-perugini wants to merge 1 commit into master
base: master
Choose a base branch
Loading
from rpc-expose-lib-dependecies

Conversation

Copy link
Contributor

@alessio-perugini alessio-perugini commented Apr 16, 2025 •
edited
Loading

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Add dependencies field in the Library struct

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

Copy link
Contributor

github-actions bot commented Apr 16, 2025 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Check Protocol Buffers / check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 22, 2025, 3:59 PM

@alessio-perugini alessio-perugini force-pushed the rpc-expose-lib-dependecies branch 2 times, most recently from 1e03f58 to 8d3292a Compare April 16, 2025 20:24
@alessio-perugini alessio-perugini added type: enhancement Proposed improvement topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface labels Apr 16, 2025
@alessio-perugini alessio-perugini changed the title (削除) libraries: expose Dependencies field (削除ここまで) (追記) Expose Dependencies field in Library struct (追記ここまで) Apr 16, 2025
Copy link

codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.85%. Comparing base (a6db55f) to head (86fcc6d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/arduino/libraries/loader.go 80.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## master #2891 +/- ##
==========================================
+ Coverage 67.83% 67.85% +0.01% 
==========================================
 Files 238 238 
 Lines 22419 22455 +36 
==========================================
+ Hits 15209 15236 +27 
- Misses 6010 6016 +6 
- Partials 1200 1203 +3
Flag Coverage Δ
unit 67.85% <87.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alessio-perugini alessio-perugini force-pushed the rpc-expose-lib-dependecies branch 3 times, most recently from 5e934ce to 2515d05 Compare April 22, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie Awaiting requested review from cmaglie

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
topic: code Related to content of the project itself topic: gRPC Related to the gRPC interface type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant

AltStyle によって変換されたページ (->オリジナル) /