-
-
Notifications
You must be signed in to change notification settings - Fork 423
fix: allow lib-install from git using revision hash as a reference #2882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cmaglie
cmaglie
added
topic: CLI
Related to the command line interface
phase: implementation
Work is in the implementation phase
criticality: medium
Of moderate impact
labels
Apr 7, 2025
@cmaglie
cmaglie
changed the title
(削除) fix: allow lib-install from git with revision hash (削除ここまで)
(追記) fix: allow lib-install from git using revision hash as a reference (追記ここまで)
Apr 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #2882 +/- ## ========================================== - Coverage 67.88% 67.82% -0.06% ========================================== Files 238 238 Lines 22410 22418 +8 ========================================== - Hits 15212 15205 -7 - Misses 6004 6012 +8 - Partials 1194 1201 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alessio-perugini
alessio-perugini
approved these changes
Apr 7, 2025
@per1234
per1234
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
A previous "fix" allowed the installation of a library from git by specifying a branch, but introduced a regression, making it impossible to install from git by specifying a revision hash.
What is the current behavior?
A library can not be installed from git using a revision hash, see #2860 for details
What is the new behavior?
It is now allowed to install from git using a revision hash.
Does this PR introduce a breaking change, and is titled accordingly?
Other information
Fix #2860