Upgrade golang version to 1.24.1 #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cmaglie merged 6 commits into arduino:master from cmaglie:updatego

Mar 31, 2025

Merged

Upgrade golang version to 1.24.1 #2850

cmaglie merged 6 commits into arduino:master from cmaglie:updatego

Mar 31, 2025

+154 −17

Conversation

cmaglie

Copy link

Member

@cmaglie cmaglie commented Feb 27, 2025

Please check if the PR fulfills these requirements

See how to contribute

The PR has no duplicates (please search among the Pull Requests
before creating one)
The PR follows
our contributing guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
UPGRADING.md has been updated with a migration guide (for breaking changes)
configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

As per subject.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement topic: infrastructure labels

Feb 27, 2025

@cmaglie cmaglie self-assigned this

Feb 27, 2025

@cmaglie

Copy link

Member Author

cmaglie commented Feb 27, 2025

Could not upgrade due to this:

2025年02月27日T10:35:36.7331257Z Installing platform opentracker:sam@1.0.5...
2025年02月27日T10:35:36.7334083Z Error during install: Cannot install platform: installing platform opentracker:sam@1.0.5: extracting archive: Create file C:\Users\runneradmin\AppData\Local\Temp\cli2305421146\A\tmp\package-1623564311円.0.5\system\libsam\build_gcc\NUL: open C:\Users\runneradmin\AppData\Local\Temp\cli2305421146\A\tmp\package-1623564311円.0.5\system\libsam\build_gcc\NUL: Incorrect function.
2025年02月27日T10:35:36.7336277Z �[90m<<< Run completed (err = exit status 1)�[0m
2025年02月27日T10:35:36.7336881Z ##[endgroup]
2025年02月27日T10:35:36.7337272Z core_test.go:1367: 
2025年02月27日T10:35:36.7338737Z 	Error Trace:	D:/a/arduino-cli/arduino-cli/internal/integrationtest/core/core_test.go:1367
2025年02月27日T10:35:36.7339517Z 	Error: 	Received unexpected error:
2025年02月27日T10:35:36.7340073Z 	 	exit status 1
2025年02月27日T10:35:36.7340628Z 	Test: 	TestCoreInstallWithWrongArchiveSize
2025年02月27日T10:35:38.3263830Z --- FAIL: TestCoreInstallWithWrongArchiveSize (10.14s)

There is a regression in golang 1.24.0: golang/go#71752, we need to wait for go1.24.1.

@cmaglie cmaglie marked this pull request as draft

February 27, 2025 10:55

cmaglie added 4 commits

March 12, 2025 18:00

@cmaglie


 Upgrade go to 1.24

5541be6

@cmaglie


 Update golanci-lint

e95d6c5

@cmaglie


 Updated license cache

e582712

@cmaglie


 Try go1.24.1

9ef0272

@cmaglie cmaglie force-pushed the updatego branch from a9902e0 to 9ef0272 Compare

March 12, 2025 17:02

@codecov Codecov

Copy link

codecov bot commented Mar 12, 2025 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.86%. Comparing base (7271e0a) to head (fb291ee).
Report is 5 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@
## master #2850 +/- ##
=======================================
 Coverage 67.86% 67.86% 
=======================================
 Files 238 238 
 Lines 22412 22412 
=======================================
 Hits 15209 15209 
 Misses 6007 6007 
 Partials 1196 1196