Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Renamed FQBN.Packager -> FQBN.Vendor #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 1 commit into arduino:master from cmaglie:fix_fqbn_field
Feb 13, 2025
Merged

Conversation

Copy link
Member

@cmaglie cmaglie commented Feb 13, 2025

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Just an API change, before publishing a package.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No, because the package is not yet published.

Other information

@cmaglie cmaglie self-assigned this Feb 13, 2025
@cmaglie cmaglie requested a review from a team February 13, 2025 13:26
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025
edited
Loading

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.77%. Comparing base (0847849) to head (37b971c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
commands/service_upload.go 0.00% 2 Missing ⚠️
internal/cli/board/list.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@
## master #2836 +/- ##
==========================================
- Coverage 67.81% 67.77% -0.05% 
==========================================
 Files 238 238 
 Lines 22402 22402 
==========================================
- Hits 15193 15184 -9 
- Misses 6020 6027 +7 
- Partials 1189 1191 +2 
Flag Coverage Δ
unit 67.77% <63.63%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit fff8658 into arduino:master Feb 13, 2025
98 checks passed
@cmaglie cmaglie deleted the fix_fqbn_field branch February 13, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucarin91 lucarin91 lucarin91 approved these changes

@MatteoPologruto MatteoPologruto MatteoPologruto approved these changes

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /